Cassandra async improvements #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fully async prepared statements * async prepared statements cache
|
build is failing https://travis-ci.org/getquill/quill/jobs/423484742#L789 |
mosyp
reviewed
Oct 4, 2018
| @@ -48,7 +48,7 @@ class CassandraAsyncContext[N <: NamingStrategy]( | |||
| executeQuery(cql, prepare, extractor).map(handleSingleResult) | |||
|
|
|||
| def executeAction[T](cql: String, prepare: Prepare = identityPrepare)(implicit ec: ExecutionContext): Future[Unit] = { | |||
| Future(prepare(this.prepare(cql))).flatMap { | |||
| this.prepareAsync(cql).map(prepare).flatMap { | |||
There was a problem hiding this comment.
I'm thinking of moving prepare into prepareAsync call or in flatMap, which can reduce additional call to ec
fwbrasil
approved these changes
Oct 5, 2018
deusaquilus
pushed a commit
to deusaquilus2/quill
that referenced
this pull request
Oct 25, 2018
* * more random prepared statements * fully async prepared statements * async prepared statements cache * * format fix * * sbt scalariformFormat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
hashCode, (simple tests produce collision with rate about 0.012%)Solution
hashCodewith more preciseHashing.goodFastHashfrom Guava