Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noFailFast option to FinagleMysqlContextConfig #1212

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Oct 29, 2018

Problem

Finagle manage clients, but sometimes we want to connect LB. At that time, it is better to set noFailFast. But FinagleMysqlContextConfig.client doesn't have such config.

Usually, it's a good idea to disable Fail Fast for server sets with only one host in the load balancer's replica set.
https://github.com/twitter/finagle/blob/b60efda72dca015b2f5921191d064fc3b0295c4e/finagle-core/src/main/scala/com/twitter/finagle/param/SessionQualificationParams.scala#L21-L35

Solution

Add noFailFast option into FinagleMysqlContextConfig.

Notes

N/A/

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@fwbrasil fwbrasil merged commit e19060a into zio:master Oct 31, 2018
@krrrr38
Copy link
Contributor Author

krrrr38 commented Oct 31, 2018

thanks 🙏

@krrrr38 krrrr38 deleted the finagle-mysql-no-fail-fast branch October 31, 2018 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants