Spark 2.4 (with Scala 2.12 support) #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
fwbrasil
reviewed
Dec 5, 2018
fwbrasil
reviewed
Dec 5, 2018
|
Thanks! The build is failing because of unformatted source files. I pick it up from here if you like. BTW, it'd be easier if we collaborate on the same branch. Also, branches in the main repo produce snapshots, so it's better than use a fork |
|
Okay, sure. I probably won’t be able to get to it tonight anyway. |
deusaquilus
force-pushed
the
spark-2_12_fix
branch
2 times, most recently
from
0dc1294
to
fe31ce7
Compare
|
it seems that there's still unformatted files: https://travis-ci.org/getquill/quill/jobs/464167819#L787 |
deusaquilus
force-pushed
the
spark-2_12_fix
branch
from
fe31ce7
to
16d8cbc
Compare
deusaquilus
force-pushed
the
spark-2_12_fix
branch
from
16d8cbc
to
66ced94
Compare
fwbrasil
approved these changes
Dec 7, 2018
fwbrasil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Switch to using columns api for null checking
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers