Fix variable shadowing issue in action metas #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusaquilus
force-pushed
the
fix_v
branch
2 times, most recently
from
aa5563f
to
8318490
Compare
jilen
requested changes
Apr 22, 2019
quill-core/src/main/scala/io/getquill/norm/capture/AvoidAliasConflict.scala
Outdated
Show resolved
Hide resolved
quill-sql/src/test/scala/io/getquill/context/sql/idiom/SqlIdiomSpec.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1408
Solution
Remove
vvariables from functions that haveActionAST elements inside of them during Parser and replace with a fresh variable usingAvoidAliasConflict.README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers