Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix java.sql.SQLException corner case #1614

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Fix java.sql.SQLException corner case #1614

merged 1 commit into from
Sep 18, 2019

Conversation

mdedetrich
Copy link
Collaborator

@mdedetrich mdedetrich commented Sep 13, 2019 •
edited
Loading

Fixes #1416. Many thanks to @oleg-py for the solution

Problem

See ticket for details

Solution

See ticket for details

  • Unit test all changes (note that we can't test this of now, see ticket for details)
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

deusaquilus
deusaquilus approved these changes Sep 18, 2019
View reviewed changes
Copy link
Collaborator

@deusaquilus deusaquilus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdedetrich mdedetrich merged commit 788fb03 into zio:master Sep 18, 2019
@mdedetrich mdedetrich deleted the fix-monix-jdbc-transaction branch September 18, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deusaquilus deusaquilus deusaquilus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.sql.SQLException: Connection is closed
2 participants
@mdedetrich @deusaquilus