Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for onConflictIgnore to H2 (v1.4.200 in PostgreSQL mode) #1731

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Added support for onConflictIgnore to H2 (v1.4.200 in PostgreSQL mode) #1731

merged 3 commits into from
Dec 18, 2019

Conversation

b-gyula
Copy link
Contributor

@b-gyula b-gyula commented Dec 11, 2019 •
edited
Loading

  • Added support for onConflictIgnore to H2 (v1.4.200 in PostgreSQL mode)
  • Doc updated with database actions return values

Fixes #1730

Problem

H2 (v1.4.200 in PostgreSQL mode) supports INSERT ... ON CONFLICT DO NOTHING
quill does not

Solution

Similarly to MySQL I've extended the H2Dialect with the onConflictIgnore

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@juliano
Copy link
Collaborator

juliano commented Dec 18, 2019

Thank you for your contribution!

@juliano juliano merged commit 39687c8 into zio:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliano juliano juliano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

H2 v1.4.200 in PostgreSQL mode supports INSERT ... ON CONFLICT DO NOTHING
2 participants
@b-gyula @juliano