-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quill-cassandra: review streaming source #185
Conversation
I'd prefer any alternative that doesn't require commenting the test. |
I would rather extend the primary key, and once they address the issue
|
@lvicentesanchez sounds good |
This should do the trick. |
1 similar comment
quill-cassandra: review streaming source
Closes #175.
As Cassandra supports pagination by default, this PR changes the way the
Observable
is created to avoid synchronous queries to Cassandra when we reach the end of current page.I have disable the
encoding sets
tests temporarily as I have found an issue with Cassandra 3.x, the version we are using for our CI. We can either use Cassandra 2.2 for our tests or add the second column ofEncodingTestEntity
to the primary key.I have reported the issue to the Cassandra Dev mailing list. This is the repo that reproduces the problem:
https://github.com/lvicentesanchez/cassandra-3.x-error