Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quill-cassandra: review streaming source #185

Merged
merged 6 commits into from
Feb 21, 2016

Conversation

lvicentesanchez
Copy link
Contributor

Closes #175.

As Cassandra supports pagination by default, this PR changes the way the Observable is created to avoid synchronous queries to Cassandra when we reach the end of current page.

I have disable the encoding sets tests temporarily as I have found an issue with Cassandra 3.x, the version we are using for our CI. We can either use Cassandra 2.2 for our tests or add the second column of EncodingTestEntity to the primary key.

I have reported the issue to the Cassandra Dev mailing list. This is the repo that reproduces the problem:

https://github.com/lvicentesanchez/cassandra-3.x-error

@fwbrasil
Copy link
Collaborator

I'd prefer any alternative that doesn't require commenting the test.

@lvicentesanchez
Copy link
Contributor Author

I would rather extend the primary key, and once they address the issue
update the CI file.
On 21 Feb 2016 16:18, "Flavio W. Brasil" notifications@github.com wrote:

I'd prefer any alternative that doesn't require commenting the test.


Reply to this email directly or view it on GitHub
#185 (comment).

@fwbrasil
Copy link
Collaborator

@lvicentesanchez sounds good

@lvicentesanchez lvicentesanchez changed the title [WIP] quill-cassandra: review streaming source quill-cassandra: review streaming source Feb 21, 2016
@lvicentesanchez
Copy link
Contributor Author

This should do the trick.

@fwbrasil
Copy link
Collaborator

awesome, thanks! :)

👍 Feel free to merge the PR once the checks are passing (it's possible to give a self-approval).

Approved with PullApprove

@lvicentesanchez
Copy link
Contributor Author

👍

Approved with PullApprove

1 similar comment
@fwbrasil
Copy link
Collaborator

👍

Approved with PullApprove

lvicentesanchez added a commit that referenced this pull request Feb 21, 2016
quill-cassandra: review streaming source
@lvicentesanchez lvicentesanchez merged commit ac1a5bb into zio:master Feb 21, 2016
@lvicentesanchez lvicentesanchez deleted the issues/175 branch February 28, 2016 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants