Fix SqlServer snake case - OUTPUT i_n_s_e_r_t_e_d.id #1867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1768
Problem
Insert returning on MS SQL Server in SnakeCase mode returns OUTPUT i_n_s_e_r_t_e_d.id
Solution
This PR introduces
ExternalIdent.Opinionated
, which allows us to define if that should beRenameable
or not. It is used inSqlIdiom
to identify the opinion and generate the token accordingly. With this change, I could remove the workaround inExpandingReturning
that would return anIdent
instead ofExternalIdent
Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers