quill-sql: H2 dialect #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvicentesanchez
force-pushed
the
issues/188
branch
from
2dc85f9
to
ef4e5c2
Compare
lvicentesanchez
force-pushed
the
issues/188
branch
from
dbd6cad
to
8bbe501
Compare
|
I have addressed all comments raised in #48. |
|
👍 |
|
LGTM but Codecov complains about missing case. If possibilities are already covered (i.e. only cases that can be) I'm fine to merge, let me know. |
|
I will try to add a test for that case, it shouldn't be that hard :) |
|
👍 |
|
@lvicentesanchez I've just noticed that this change wasn't reflected on the readme, could you fix it? |
|
Sure. I will do a quick PR. 2016-02-29 4:53 GMT+00:00 Flavio W. Brasil notifications@github.com:
|
jilen
pushed a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188.
Continuation of the previous PR. It's still WIP, I need to review all comments from previous closed PR.