implement postgres naming strategy; fixes #215 #218
Conversation
|
@fwbrasil @gustavoamigo @lvicentesanchez @jilen please review. p.s. I've noticed builds in last couple of PRs have been failing on MySQLAsync/PostgresAsync. Rebuild passes though, not sure if temporary or something to look into. |
| @@ -80,11 +80,15 @@ trait CamelCase extends NamingStrategy { | |||
| } | |||
| object CamelCase extends CamelCase | |||
|
|
|||
| trait PostgresEscape extends Escape { | |||
| override def column(s: String) = if (s.startsWith("$")) s else default(s) | |||
There was a problem hiding this comment.
Why not else super.column(s)?
There was a problem hiding this comment.
never mind, clean build solved AbstractMethodError I was getting, will update PR.
I'll grab stack trace if spurious build error occurs again.
|
👍 |
implement postgres naming strategy; fixes #215
|
@godenji Thanks for the quick fix! :) |
|
@fwbrasil speaking of quick fixes there's actually a bunch of cleanup work to do (various typos in source files and readme phrasing/grammar) before you give your ScalaDays talk in Berlin 😄 I'll try to make note of them as they come up, get distracted by the interesting work and then forget the little details... |
|
@godenji awesome! looking forward to it! |
|
@godenji I've just noticed that this change wasn't reflect in the readme, could you fix it? |
No description provided.