Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quilll-sql: support value queries #354

Merged
merged 2 commits into from
May 10, 2016
Merged

quilll-sql: support value queries #354

merged 2 commits into from
May 10, 2016

Conversation

fwbrasil
Copy link
Collaborator

@fwbrasil fwbrasil commented May 9, 2016

Fixes #341

Problem

Quill doesn't support selecting values or operations.

db.run(qr1.map(_.i).contains(1))
db.run(1)

Solution

Change SqlQuery to support this kind of quotations.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@gustavoamigo
Copy link
Contributor

gustavoamigo commented May 9, 2016 •
edited by fwbrasil
Loading

👍

Approved with PullApprove

@gustavoamigo
Copy link
Contributor

gustavoamigo commented May 9, 2016 •
edited by fwbrasil
Loading

👍

Approved with PullApprove

1 similar comment
@fwbrasil
Copy link
Collaborator Author

fwbrasil commented May 10, 2016 •
edited
Loading

👍

Approved with PullApprove

@fwbrasil fwbrasil merged commit de6456d into master May 10, 2016
@fwbrasil fwbrasil deleted the fix341 branch May 10, 2016 00:40
jilen pushed a commit that referenced this pull request Jun 11, 2024
@dependabot
Bump actions/checkout from 4.0.0 to 4.1.0 (#354)
5f8eaa6 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwbrasil @gustavoamigo