added handling for string lists in ClusterBuilder #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private def param(key: String, tpe: Class[_], cfg: Config) = | ||
| Try { | ||
| if (tpe == classOf[String]) | ||
| cfg.getString(key) | ||
| else if (tpe == stringArrayClass) | ||
| cfg.getStringList(key).asScala.toArray |
There was a problem hiding this comment.
simply calling toArray without explicit asScala did not work for some reason
|
@ksilin thanks! :) |
jilen
pushed a commit
that referenced
this pull request
Jun 11, 2024
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.13.0 to 4.0.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3.13.0...v4.0.0) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388
Problem
configuration
contactPoints = ["127.0.0.1", "127.0.0.2"]should create a validdatastax.driver.core.Cluster#Builderby using theaddContactPointsmethod.Solution
added another
else ifblock inClusterBuilder#paramNotes
addContactPoints(String...)is the only relevant varargs signature inBuilder, so I only took care of adding and testing string listsChecklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers