Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create sub query if aggregation on distinct query #472

Merged
merged 1 commit into from
Jul 24, 2016

Conversation

jilen
Copy link
Collaborator

@jilen jilen commented Jul 24, 2016

Fixes #436

Problem

Aggregation on distinct query will break the SELECT semantic

Solution

Produce sub query if aggerate on distinct query

Notes

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@fwbrasil
Copy link
Collaborator

fwbrasil commented Jul 24, 2016

👍

Approved with PullApprove

@gustavoamigo
Copy link
Contributor

gustavoamigo commented Jul 24, 2016

👍

Approved with PullApprove

@fwbrasil fwbrasil merged commit 1f823d6 into zio:master Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants