Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix class cast exception for returned values #536

Merged
merged 1 commit into from
Aug 24, 2016
Merged

fix class cast exception for returned values #536

merged 1 commit into from
Aug 24, 2016

Conversation

fwbrasil
Copy link
Collaborator

Fixes #533

Problem

Drivers that don't support reading arbitrary returning types from action executions don't use the extractor instance, producing a class cast exception if the id is a WrappedValue.

Solution

Create single-element rows and use the extractor instance.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@gustavoamigo
Copy link
Contributor

gustavoamigo commented Aug 24, 2016

👍

Approved with PullApprove

@fwbrasil fwbrasil merged commit 2dd769f into master Aug 24, 2016
@fwbrasil fwbrasil deleted the fix-533 branch August 24, 2016 13:58
@zifeo
Copy link
Contributor

zifeo commented Aug 24, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants