Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make currentConnection protected #628

Merged
merged 1 commit into from
Nov 17, 2016
Merged

make currentConnection protected #628

merged 1 commit into from
Nov 17, 2016

Conversation

schmitch
Copy link
Contributor

@schmitch schmitch commented Nov 16, 2016

Problem

Actually at the moment it's really hard to convert our JDBC code to quill due to the fact that we can't override/change the currentConnection.

At the moment we just want to create a Adapter that takes a implicit connection and does the same thing like transaction except getting a Connection via withConnection.

Solution

Sets currentConnection to protected.

Current way: override transaction and withConnection and using our own currentConnection.

Notes

none

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

use case: creating a transaction adapter between other jdbc libraries and quill

use case: creating a transaction adapter between other jdbc libraries and quill
@fwbrasil
Copy link
Collaborator

@schmitch thanks! :)

@fwbrasil fwbrasil merged commit 5142bb0 into zio:master Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants