Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Actually at the moment it's really hard to convert our JDBC code to quill due to the fact that we can't override/change the
currentConnection
.At the moment we just want to create a Adapter that takes a
implicit connection
and does the same thing liketransaction
except getting aConnection
viawithConnection
.Solution
Sets
currentConnection
toprotected
.Current way: override transaction and withConnection and using our own currentConnection.
Notes
none
Checklist
README.md
if applicable[WIP]
to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormat
to make sure that the source files are formatted@getquill/maintainers
use case: creating a transaction adapter between other jdbc libraries and quill