Materialize encoding for generic value class. #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with "value class". Remove duplicated test in EncodeBindVariablesSpec.scala (the same one is in ContextMacroSpec.scala).
This was referenced Dec 2, 2016
Closed
mxl
changed the title
|
@getquill/maintainers Could somebody review this PR? |
fwbrasil
approved these changes
Dec 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #655
Problem
Generic value class encoder materialization does not respect it's real type parameter.
Solution
Get value class constructor signature with
m.typeSignature.asSeenFrom(t, t.typeSymbol).Notes
Replaced "wrapped value" with "value class" terminology.
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers