Recursive optional nested expanding. #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxl
commented
Dec 23, 2016
| (("a", Some((Entity1("1", 2), Entity2(Some(3)))))) | ||
| } | ||
| "extracts None if one column is undefined" in { | ||
| meta.extract(Row("a", Some("1"), None, Some(Some(3)))) mustEqual |
There was a problem hiding this comment.
Not sure about Some(Some(3)). I think it should able to extract Some(3) but now it's failing. Will try to fix that.
There was a problem hiding this comment.
besides this problem, the fix looks good
mxl
changed the title
mxl
changed the title
|
@fwbrasil Done. |
fwbrasil
approved these changes
Dec 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #667
Should fix #668
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers