Add raw joda time encoding to quill-async
#837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@getquill/maintainers I guess we need |
mxl
suggested changes
Jul 15, 2017
| "decode local date time types" in { | ||
| case class DateEncodingTestEntity(v1: LocalDateTime, v2: LocalDateTime, v3: LocalDateTime) | ||
| "decode local date types and local date time type" in { | ||
| case class DateEncodingTestEntity(v1: LocalDate, v2: LocalDateTime, v3: LocalDateTime) |
There was a problem hiding this comment.
Could you remove v3 field? It duplicates v2.
Also it's better to change test name to "decode LocalDate and LocalDateTime types".
There was a problem hiding this comment.
v3 has different sql type so let's keep it, to double-sure everything's ok
| "decode local date types" in { | ||
| case class DateEncodingTestEntity(v1: LocalDate, v2: LocalDate, v3: LocalDate) | ||
| val entity = DateEncodingTestEntity(LocalDate.now, LocalDate.now, LocalDate.now) | ||
| "encodes joda local date and local date time type" in { |
There was a problem hiding this comment.
May be change it to "decode joda LocalDate and LocalDateTime types" just for consistency with other tests names and correct class names?
| "encodes localdate type" in { | ||
| case class DateEncodingTestEntity(v1: LocalDate, v2: LocalDate) | ||
| val entity = DateEncodingTestEntity(LocalDate.now, LocalDate.now) | ||
| "encodes joda localdate and localdatetime type" in { |
There was a problem hiding this comment.
Let's use correct case for class name here - LocalDate and LocalDateTime. WDYT?
| "encodes localdatetime type" in { | ||
| case class DateEncodingTestEntity(v1: LocalDateTime, v2: LocalDateTime) | ||
| val entity = DateEncodingTestEntity(LocalDateTime.now, LocalDateTime.now) | ||
| "encodes localdate and localdatetime type" in { |
mxl
approved these changes
Jul 15, 2017
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
Problem
Async driver support joda time by default but raw encoders are missing
Solution
Notes
Breaking Changes!
java.time.LocalDatenow supports only date sql types,java.time.LocalDateTime- onlytimestampsql types. Joda times follow this conventions accordingly.Exception is made to
java.util.Dateit supports bothdateandtimestamptypes due to historical moments (java.sql.Timestampextentsjava.util.Date)Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers