Fix renaming properties for flat joins #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosyp
commented
Sep 7, 2017
| @@ -80,7 +80,7 @@ object RenameProperties extends StatelessTransformer { | |||
| case (a, schemaA) => | |||
| val replaceA = replacements(iA, schemaA) | |||
| val onr = BetaReduction(on, replaceA: _*) | |||
| (FlatJoin(typ, a, iA, onr), Tuple(List(schemaA))) | |||
| (FlatJoin(typ, a, iA, onr), schemaA) | |||
There was a problem hiding this comment.
replacements function later prepends x._1. to path hence BetaReduction could not properly replace aliases
mosyp
commented
Sep 7, 2017
| } yield x.map(x => x.i -> x.s) | ||
| } | ||
| testContext.run(q).string mustEqual | ||
| "SELECT b.field_i, b.field_s FROM TestEntity2 a LEFT JOIN test_entity b ON a.s = b.field_s" |
There was a problem hiding this comment.
Before patch it was like
SELECT b.i, b.s FROM TestEntity2 a LEFT JOIN test_entity b ON a.s = b.field_s
fwbrasil
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859
Problem
When using flat joins, rename properties via querySchema/schemaMeta didn't work.
Solution
Fix the issue, more in comments to patch
Checklist
README.mdif applicable[WIP]to the pull request title if it's work in progresssbt scalariformFormat test:scalariformFormatto make sure that the source files are formatted@getquill/maintainers