Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix group by alias conflict and don't apply join(groupby.map) #899

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

fwbrasil
Copy link
Collaborator

Fixes #410

Problem

#410 involves two bugs:

  • AvoidAliasConflict doesn't consider GroupBy
  • ApplyMap doesn't avoid applying maps that are associated to a groupby

Solution

Fix the issues

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant