Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail if expression uses a table #906

Merged
merged 1 commit into from
Sep 21, 2017
Merged

fail if expression uses a table #906

merged 1 commit into from
Sep 21, 2017

Conversation

fwbrasil
Copy link
Collaborator

Fixes #702
Fixes #248

Problem

Quill doesn't fail if the user query uses a table instead of a specific column. See #702 for more details.

Solution

Fail if this kind of AST is being compiled into a query.

Notes

I had to fix #248 in order to fix the bug.

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@fwbrasil fwbrasil merged commit c644c5e into master Sep 21, 2017
@fwbrasil fwbrasil deleted the fix-702 branch September 21, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid compilation of wrong query Create ast for Option existence check
1 participant