Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finagle to 17.11.0 #976

Merged
merged 1 commit into from
Nov 27, 2017
Merged

Conversation

writa
Copy link

@writa writa commented Nov 27, 2017

Fixes #issue_number

Problem

Finagle 17.11.0 was released, but we use the old version of it.

Solution

Update finagle mysql

Notes

Checklist

  • Unit test all changes
  • Update README.md if applicable
  • Add [WIP] to the pull request title if it's work in progress
  • Squash commits that aren't meaningful changes
  • Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@writa writa changed the title Update finagle to 17.11.0 [WIP] Update finagle to 17.11.0 Nov 27, 2017
Copy link
Contributor

@golem131 golem131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mosyp mosyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mosyp mosyp merged commit efabfc8 into zio:master Nov 27, 2017
@writa writa changed the title [WIP] Update finagle to 17.11.0 Update finagle to 17.11.0 Nov 27, 2017
@writa writa deleted the feature/finagle-update-to-17.11.0 branch November 27, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants