Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing a parameter value in the UI causes an alert() when you haven't saved the query #1174

Closed
tsibley opened this issue Jul 6, 2016 · 5 comments · Fixed by #1232
Closed

Comments

@tsibley
Copy link
Contributor

tsibley commented Jul 6, 2016

Open up a query's source and modify it. If it doesn't have a parameter already, add one. Without saving, modify the parameter's value in the input field. The real-time location updating while typing into the parameter input field triggers the "If you leave this page you'll lose your changes" alert. Save the query and then try typing in the parameter's input field. It updates the location without triggering an alert().

@arikfr
Copy link
Member

arikfr commented Jul 7, 2016

I've tried to reproduce it here: http://demo.redash.io/queries/2081/source and couldn't. Are you running the latest version the 0.11 release?

If not, can you upgrade and see if you still experience this?
If you're running the latest, can you add more details on your browser/OS?

@tsibley
Copy link
Contributor Author

tsibley commented Jul 7, 2016

Hmm, apologies for not including my version in the initial report. I observed this running v0.12.0-rc.

@tsibley
Copy link
Contributor Author

tsibley commented Jul 7, 2016

Browser is Chrome 51.0.2704.103, OS X.

@tsibley
Copy link
Contributor Author

tsibley commented Jul 7, 2016

I can reproduce it on demo.redash.io. Try this:

  1. Create a new query
  2. Enter select '{{foo}}' and save the query
  3. Modify the query to select '{{foo}}' || 'bar', but don't save it
  4. Type something in the parameter input for "foo"

If the query is completely new and never been saved, it doesn't happen for me, hence why maybe you couldn't reproduce it.

@arikfr
Copy link
Member

arikfr commented Jul 11, 2016

Ok, now I see what's going on. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants