Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading custom JS chart into editor fails. #1628

Closed
deecay opened this issue Feb 23, 2017 · 0 comments · Fixed by #1873
Closed

Loading custom JS chart into editor fails. #1628

deecay opened this issue Feb 23, 2017 · 0 comments · Fixed by #1873

Comments

@deecay
Copy link
Contributor

deecay commented Feb 23, 2017

Issue Summary

Saved custom JS chart visualization does not load in editor.

Steps to Reproduce

  1. Select Custom Plotly chart and select xAxis and a yAxis.
    I chose select ID, org_id from events LIMIT 10 from Redash metadata.

  2. Paste the following to Custom Code.
    Line chart correctly renders.

Plotly.plot( element, [{
    x: x,
    y: ys }]);
  1. Save

  2. Click Edit.
    The error is raised and I see default template comments in Custom Code. Am I doing something wrong?

angular.js?3437:13920 SyntaxError: Unexpected end of input
    at refresh (eval at <anonymous> (app.d5b5662….js:1196), <anonymous>:501:92)
    at eval (eval at <anonymous> (app.d5b5662….js:1196), <anonymous>:527:9)
    at Scope.$digest (eval at <anonymous> (vendor.d6c0067….js:486), <anonymous>:17524:23)
    at ChildScope.$apply (eval at <anonymous> (vendor.d6c0067….js:486), <anonymous>:17790:24)
    at HTMLButtonElement.eval (eval at <anonymous> (vendor.d6c0067….js:486), <anonymous>:25890:23)
    at defaultHandlerWrapper (eval at <anonymous> (vendor.d6c0067….js:486), <anonymous>:3497:11)
    at HTMLButtonElement.eventHandler (eval at <anonymous> (vendor.d6c0067….js:486), <anonymous>:3485:9)
(anonymous) @ angular.js?3437:13920
(anonymous) @ angular.js?3437:10467
$digest @ angular.js?3437:17542
$apply @ angular.js?3437:17790
(anonymous) @ angular.js?3437:25890
defaultHandlerWrapper @ angular.js?3437:3497
eventHandler @ angular.js?3437:3485
angular.js?3437:13920 SyntaxError: Unexpected end of input
    at refresh

Technical details:

  • Redash Version: 1.0.0 pulled from HEAD on Feb. 22nd
  • Browser/OS: Chrome
  • How did you install Redash: Docker with dev setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant