Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom color option in color picker #2480

Closed
arikfr opened this issue Apr 22, 2018 · 4 comments
Closed

Add custom color option in color picker #2480

arikfr opened this issue Apr 22, 2018 · 4 comments

Comments

@arikfr
Copy link
Member

arikfr commented Apr 22, 2018

(when picking a color for a chart series, for example)

We need to make sure that we use a single component for color picking across the application, so we don't have to redo this in every other visualization.

(Related: #2476)

@arikfr
Copy link
Member Author

arikfr commented Dec 4, 2018

We go down this path we should probably show the user previously picked colors, so they can be consistent in their choices. This will implicitly implement #2481.

@arikfr
Copy link
Member Author

arikfr commented Oct 7, 2019

#4136 implemented the component, we just need to make sure to use it everywhere now...

@arikfr
Copy link
Member Author

arikfr commented Jan 19, 2020

@kravets-levko I guess we can close this now?

@kravets-levko
Copy link
Collaborator

@arikfr I think yes - color picker now has an input where user can type any color (in CSS hexadecimal format or predefined CSS constants like red/yellow/etc.)

@arikfr arikfr closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants