Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Spreadsheets: when the spreadsheet not found show the service account email address #2940

Open
arikfr opened this issue Oct 14, 2018 · 12 comments
Labels
Backend hacktoberfest Hacktoberfest Friendly Issues UX

Comments

@arikfr
Copy link
Member

arikfr commented Oct 14, 2018

When trying to query a Google Spreadsheet and it wasn't found, as part of the message to the user show the service account email address.

Reasoning: many times the user tries to share it with their own email address or just not sure what address to share it with.

The Google Spreadsheet query runner implemented in this module:
https://github.com/getredash/redash/blob/master/redash/query_runner/google_spreadsheets.py

Will need to alter this error message:

return None, "Spreadsheet ({}) not found. Make sure you used correct id.".format(key)

The service account email address is in the JSON key file.

@arikfr arikfr added Backend UX hacktoberfest Hacktoberfest Friendly Issues labels Oct 14, 2018
@adityashrm21
Copy link

adityashrm21 commented Oct 14, 2018

Can you tell a bit more about how to extract the service account email address through jsonkeyfile? I could not figure it out.

@arikfr
Copy link
Member Author

arikfr commented Oct 14, 2018

Sure!

key = json_loads(b64decode(self.configuration['jsonKeyFile']))

^ this is how the key file contents file are being loaded. Then there is a key which is the service account email (I think it's client_email).

@YashJipkate
Copy link

Hi @arikfr, Is this issue still up for grabs? I'd like to work on this.
Thanks!

@arikfr
Copy link
Member Author

arikfr commented Oct 7, 2019

@YashJipkate thank you, but there are actually two open PRs for this issue. Both need some small changes, but probably there is no need for another implementation 😬

Would you like to work on something else?

@kurianbenoy
Copy link

Is this issue still not solved @arikfr ?

@Dyex719
Copy link

Dyex719 commented Apr 5, 2023

If this issue is still open, can I work on it?

@arikfr
Copy link
Member Author

arikfr commented Apr 5, 2023

@Dyex719 yes, thanks! But check the old pull requests. At this point I don't remember what were the small changes needed, but you can probably get some ideas there.

@robokage
Copy link

Hi @arikfr if this issue is still open, I would like to work on it as part of hacktoberfest 2023. So please let me know

@guidopetri
Copy link
Contributor

@robokage sure, feel free to open a PR and tag me on it :)

@robokage
Copy link

@robokage sure, feel free to open a PR and tag me on it :)

Great I'll start working on it

@mohammed-anwar404
Copy link

hey @arikfr This is my first time participating in Hacktoberfest. I have python as my primary skill and would definitely want to contribute.
Please let me know if this issue can be assigned to me.

@mohammed-anwar404
Copy link

Hey, I am new to hactoberfest looking to contribute to my first project. If this is a beginner-friendly issue I would like to contribute with some guidance from your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend hacktoberfest Hacktoberfest Friendly Issues UX
Projects
None yet
Development

No branches or pull requests

8 participants