fix: masking inputs on change when maskAllInputs:false
#61
Conversation
Since `maskInputSelector` is a new configuration item, we were not handling the case for input change when `maskAllInputs:false`. Before, input masking was only done via `maskInputOptions` and `maskAllInputs`.
billyvg
changed the title
maskAllInputs:falsemaskAllInputs:false
…olved before attempting to mask
| hasInputMaskOptions({ | ||
| maskInputOptions, | ||
| maskInputSelector, | ||
| tagName: (target as HTMLElement).tagName, | ||
| type, | ||
| }) |
There was a problem hiding this comment.
Previous PR I had removed this condition, but that meant it was calling maskInputValue on every change, so hasInputMaskOptions is called before maskInputValue. Worst case it will get called twice (it's also called in maskInputValue to determine if it needs masking), but hasInputMaskOptions avoids calling el.matches()/closest() which is a bit costlier than the O(1) lookups in hasInputMaskOptions.
| hasInputMaskOptions({ | ||
| maskInputOptions, | ||
| maskInputSelector, | ||
| tagName: (target as HTMLElement).tagName, | ||
| type, | ||
| }) |
| * Check `maskInputOptions` if the element, based on tag name and `type` attribute, should be masked. | ||
| * If `<input>` has no `type`, default to using `type="text"`. | ||
| */ | ||
| function isInputTypeMasked({ |
There was a problem hiding this comment.
I'm probably missing something but why does this function not simply return a boolean? I checked usages and it seems like it's only used in if conditions anyway. I guess we wouldn't need the interface then either.
There was a problem hiding this comment.
Hmm? It does return a boolean... are the parens throwing you off? (prettier added them)
There was a problem hiding this comment.
Lol, sorry - it does of course. Yup, mistook the param type as the return type. Weekend here I come 😅
| /** | ||
| * Determine if there are masking options configured and if `maskInputValue` needs to be called | ||
| */ | ||
| export function hasInputMaskOptions({ |
Since
maskInputSelectoris a new configuration item, we were not handling the case for input change whenmaskAllInputs:false. Before, input masking was only done viamaskInputOptionsandmaskAllInputs.