Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Create a new release #16

Closed
ys opened this issue May 8, 2017 · 14 comments
Closed

Create a new release #16

ys opened this issue May 8, 2017 · 14 comments

Comments

@ys
Copy link

ys commented May 8, 2017

A lot of changes have been made, would it be possible to cut a new release?

@ys
Copy link
Author

ys commented Jul 19, 2017

@dcramer can we have that? Pretty please

@nhumrich
Copy link

nhumrich commented Oct 5, 2017

What do you need a new release for? This isnt in pypi or anything, the pip install instructions install directly from master

@ys
Copy link
Author

ys commented Oct 6, 2017

Ended up having -e git+https://github.com/getsentry/sentry-auth-google.git@master#egg=sentry-auth-google in my requirements.in but... yeah

@ianwestcott
Copy link

This is, in fact, on PyPI, and the version there is outdated: https://pypi.python.org/pypi/sentry-auth-google

I second the request to cut a new release, and would like to see it published to PyPI as well. Installing directly from git is cumbersome to automate.

@mattrobenolt
Copy link

Installing directly from git is cumbersome to automate.

Why so? You can use pip to install directly with a sha.

@ianwestcott
Copy link

You can use pip to install directly with a sha.

It's easy enough to install, yes. What's cumbersome is to verify later that a specific version of the plugin is installed on a system, which is important for automated installations.

I understand that it's not impossible to do it this way, but IMO it's far better to simply specify a version and have pip install that version from PyPI.

@ys
Copy link
Author

ys commented Nov 10, 2017

Simplicity and maintainability of a project as big as sentry is a big plus.
Having dependencies easily integrated without worrying and with clear versioning is definitively a plus.

Thanks @ianwestcott

@jvigneux
Copy link

jvigneux commented Jan 3, 2018

The release 0.1.0 does not seems to work with sentry 8.22 onpremise, and neither does the master branch with sentry 8.22:
File "/usr/local/lib/python2.7/site-packages/sentry_auth_google/provider.py", line 3, in <module> from sentry.auth.provider import MigratingIdentityId

Releases with a compatibility matrix with sentry and the plugin versions could be helpfull.

@jvigneux
Copy link

jvigneux commented Jan 4, 2018

Nevermind, the 0.1.0 release works with sentry 8.22 , it is just that on top of the IAM api, the Google+ api needs to be enabled as well for sso.

@aleksihakli
Copy link

I've tried the new SSO plugin and the new Google plugin today with the newest stable Sentry version and both of these are broken with multiple upstream releases of this plugin. Would be very nice if there were stable version releases on PyPI for these components, it's really frustrating to run into problems in one plugin after another. The least sane versioning scheme would be release tags on GitHub or release branches to indicate which versions are compatible with which Sentry versions.

@SeanSith
Copy link

Cutting a new release to PyPI would be preferred as many of us have to migrate from 0.1.0 to master in order to avoid the complications from Google+ API shutdown.

@dcramer
Copy link
Member

dcramer commented Jan 29, 2019

I'm going to cut a new release as this integration is unlikely to have major changes in the future.

@dcramer
Copy link
Member

dcramer commented Jan 29, 2019

I published 0.2.0. Please let us know if you see any issues with it.

@dcramer dcramer closed this as completed Jan 29, 2019
@dcramer
Copy link
Member

dcramer commented Jan 29, 2019

We're also going to vendor sentry-auth-google into the Sentry 9.x release series as maintaining duplicate configurations of CI providers has become a nightmare for us. It also ensures that its always tested with every change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants