Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sourcemaps uploaded when build with environment variable NODE_ARGS #1039

Closed
hermanho opened this issue Sep 30, 2021 · 1 comment
Closed

Comments

@hermanho
Copy link

Environment

How do you use Sentry?
sentry.io
sentry-cli 1.68.0
xcode 12.5
react-native 0.63

Steps to Reproduce

  1. Add environment variable NODE_ARGS in shell or CICD, eg export NODE_ARGS="--max-old-space-size=8192"
  2. Build react-native in xcode. here is the code of "Bundle React Native code and images"
#!/usr/bin/env bash
set -e

export EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map"
../node_modules/@sentry/cli/bin/sentry-cli react-native xcode --force-foreground ../node_modules/react-native/scripts/react-native-xcode.sh

Expected Result

Sourcemaps should be uploaded to sentry. Here is an example of xcode logging

+ /opt/JetBrains/TeamCity/buildAgent/work/2cb4c0ba138a0c8d/node_modules/@sentry/cli/sentry-cli /opt/JetBrains/TeamCity/buildAgent/work/2cb4c0ba138a0c8d/node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --reset-cache --bundle-output /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-awojveswsdzoexgaxgrdoutgdffe/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app/main.jsbundle --assets-dest /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-awojveswsdzoexgaxgrdoutgdffe/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app --sourcemap-output /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-awojveswsdzoexgaxgrdoutgdffe/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/IntermediateBuildFilesPath/fwdmobile.build/Release-iphoneos/fwdmobile.build/DerivedSources/main.jsbundle.map
metro cacheDirRoot /opt/JetBrains/TeamCity/buildAgent/temp/buildTmp/metro-cache/prod
warning: the transform cache was reset.
                 Welcome to React Native!
                Learn once, write anywhere


info Writing bundle output to:, /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-awojveswsdzoexgaxgrdoutgdffe/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app/main.jsbundle
info Writing sourcemap output to:, /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-awojveswsdzoexgaxgrdoutgdffe/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/IntermediateBuildFilesPath/fwdmobile.build/Release-iphoneos/fwdmobile.build/DerivedSources/main.jsbundle.map
info Done writing bundle output
info Done writing sourcemap output
info Copying 202 asset files
info Done copying assets
+ [[ false != true ]]
+ [[ ! -f /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-awojveswsdzoexgaxgrdoutgdffe/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app/main.jsbundle ]]
Processing react-native sourcemaps for Sentry upload.
> Analyzing 2 sources
> Rewriting sources
> Adding source map references
> Bundled 2 files for upload
> Uploaded release files to Sentry
> File upload complete (processing pending on server)

Source Map Upload Report
  Minified Scripts
    ~/main.jsbundle (sourcemap at main.jsbundle.map)
  Source Maps
    ~/main.jsbundle.map

Actual Result

Here is a failed result of xcode logging

+ /opt/JetBrains/TeamCity/buildAgent2/work2/2cb4c0ba138a0c8d/node_modules/@sentry/cli/sentry-cli --max-old-space-size=8192 /opt/JetBrains/TeamCity/buildAgent2/work2/2cb4c0ba138a0c8d/node_modules/react-native/cli.js bundle --entry-file index.js --platform ios --dev false --reset-cache --bundle-output /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-deqrvnnbcqtiqfdliqexdhzujyxa/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app/main.jsbundle --assets-dest /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-deqrvnnbcqtiqfdliqexdhzujyxa/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app --sourcemap-output /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-deqrvnnbcqtiqfdliqexdhzujyxa/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/IntermediateBuildFilesPath/fwdmobile.build/Release-iphoneos/fwdmobile.build/DerivedSources/main.jsbundle.map
metro cacheDirRoot /opt/JetBrains/TeamCity/buildAgent2/temp2/buildTmp/metro-cache/prod
warning: the transform cache was reset.
                 Welcome to React Native!
                Learn once, write anywhere


info Writing bundle output to:, /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-deqrvnnbcqtiqfdliqexdhzujyxa/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app/main.jsbundle
info Writing sourcemap output to:, /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-deqrvnnbcqtiqfdliqexdhzujyxa/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/IntermediateBuildFilesPath/fwdmobile.build/Release-iphoneos/fwdmobile.build/DerivedSources/main.jsbundle.map
info Done writing bundle output
info Done writing sourcemap output
info Copying 202 asset files
info Done copying assets
+ [[ false != true ]]
+ [[ ! -f /Users/ec2-user/Library/Developer/Xcode/DerivedData/fwdmobile-deqrvnnbcqtiqfdliqexdhzujyxa/Build/Intermediates.noindex/ArchiveIntermediates/fwd-Release/BuildProductsPath/Release-iphoneos/fwdmobile.app/main.jsbundle ]]
Warning: build produced no sourcemaps.
@kamilogorek
Copy link
Contributor

This is issue with the react-native and xcode setup itself, not the CLI.

ref: getsentry/sentry-react-native#473 (comment)
ref: getsentry/sentry-react-native#576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants