Refactor integration tests so they can be run locally #2132
Replies: 4 comments 3 replies
-
The benefits of not forking is that we keep trying our SDK with new stuff when this other projects are updated. |
Beta Was this translation helpful? Give feedback.
-
I didn't create forks because I wanted to keep it lightweight. I just patched things together to make it work. Of course, a significant downside of the current solution is that you can't easily run it locally. If you want you can change it to what you suggested. |
Beta Was this translation helpful? Give feedback.
-
I would be interested in why you want to improve this. Do you have to touch that often, @armcknight? Is it worth the effort to improve this right now? |
Beta Was this translation helpful? Give feedback.
-
Integration tests were removed in #2916 |
Beta Was this translation helpful? Give feedback.
-
Description
I have a problem on a PR with one of the integration tests, but don't see an easy way to run them locally without a bunch of manual steps.
I plan to write a couple makefile tasks to automate this.
A couple questions about the current implementation:
path
directive instead of thecommit
directive used e.g. here. This would avoid a call over the network.master
? Wouldgit rev-parse HEAD
not work in all cases?Beta Was this translation helpful? Give feedback.
All reactions