Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could provide a version adapted for Android 15 with a 16KB size limit? #2237

Closed
1 task done
wyqlxf opened this issue Aug 19, 2024 · 9 comments
Closed
1 task done

Could provide a version adapted for Android 15 with a 16KB size limit? #2237

wyqlxf opened this issue Aug 19, 2024 · 9 comments

Comments

@wyqlxf
Copy link

wyqlxf commented Aug 19, 2024

Problem Statement

https://developer.android.com/guide/practices/page-sizes?hl=zh-cn

Solution Brainstorm

No response

Are you willing to submit a PR?

None

Depends on

Preview Give feedback
  1. Platform: Java Platform: Native
    markushi
@buenaflor
Copy link
Contributor

hi we'll have a look

@buenaflor buenaflor moved this from Needs Discussion to Needs Investigation in Mobile & Cross Platform SDK Aug 20, 2024
@buenaflor buenaflor moved this from Needs Investigation to Blocked in Mobile & Cross Platform SDK Aug 29, 2024
@buenaflor
Copy link
Contributor

Currently blocked by getsentry/sentry-java#3657

@wyqlxf wyqlxf closed this as completed Sep 26, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Mobile & Cross Platform SDK Sep 26, 2024
@kahest kahest reopened this Sep 26, 2024
@buenaflor buenaflor moved this from Done to Needs Discussion in Mobile & Cross Platform SDK Sep 26, 2024
@buenaflor buenaflor moved this from Needs Discussion to Blocked in Mobile & Cross Platform SDK Sep 26, 2024
@kahest
Copy link
Member

kahest commented Nov 5, 2024

there's a prerelease out on Android (7.17.0-alpha.1) for testing

@denrase
Copy link
Collaborator

denrase commented Nov 12, 2024

I checked with Android 7.17.0-alpha.1 with the scrip provided by google. It was broken but after playing around, i was able to fix it.

The page sizes are aligned for our Android dependency, but we need to check Isar and SQLite dependencies. This was the sample app. I'm not sure where libnative-sample is coming from.

Results are the same for arch arm64-v8a and armeabi-v7a.

=== ELF alignment ===
app-release/lib/arm64-v8a
libapp.so		libnative-sample.so	libsqlite3.so
libflutter.so		libsentry-android.so
libisar.so		libsentry.so
app-release/lib/arm64-v8a/libsentry.so: \e[32mALIGNED\e[0m (2**14)
app-release/lib/arm64-v8a/libflutter.so: \e[32mALIGNED\e[0m (2**16)
app-release/lib/arm64-v8a/libapp.so: \e[32mALIGNED\e[0m (2**16)
app-release/lib/arm64-v8a/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
app-release/lib/arm64-v8a/libisar.so: \e[31mUNALIGNED\e[0m (2**12)
app-release/lib/arm64-v8a/libnative-sample.so: \e[31mUNALIGNED\e[0m (2**12)
app-release/lib/arm64-v8a/libsqlite3.so: \e[31mUNALIGNED\e[0m (2**12)

@markushi
Copy link
Member

FYI: We shipped the 16kb support with the 7.18.0 release of the Android SDK.

@denrase
Copy link
Collaborator

denrase commented Nov 25, 2024

I updated our sample app to support 16kb pages by bumping NDK to 27 and updating the app/build.gradle as described in here . I works on a 16KB emulator device, also with our Isar and SQFlite packages. This only works where we have Sentry Android 7.18.0 SDK, so users also need to upgrade to Sentry 8.11.0-beta.1

@kahest kahest moved this from Todo to In Progress in Mobile & Cross Platform SDK Nov 25, 2024
@buenaflor
Copy link
Contributor

@denrase perfect, so it's a matter of documenting it and using at least 8.11.0-beta.1 👍

@denrase
Copy link
Collaborator

denrase commented Nov 25, 2024

@buenaflor We support it from 8.11.0-beta.1. Apart from that, the setup for 16 KB pages is unrelated to Sentry, so i don't think we should provide additional documentation, apart from stating that we support it. WDYT?

@buenaflor
Copy link
Contributor

buenaflor commented Nov 26, 2024

@denrase I think we should at least say that the setup is required (and link there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
Development

No branches or pull requests

5 participants