-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promo Banners #11532
Comments
Assigning to @getsentry/support for routing ⏲️ |
@elijames-codecov we can have banners across all pages easily reusing the same component (and dismissibility) behavior what would an ideal fine grained control over which pages to show a certain banner look like from an author's POV / dream DX? |
@a-hariti - if you look at static-sites' banner, we list each page or directory we want each banner to appear in. If we can mimic that functionality, that would keep it consistent which makes it easier to maintain. Here's a code snippet of how this is currently controlled on static-sites. The
|
Nice pattern! Can you give the repo where it's being used? |
|
I think this repo is not visible to me |
I added you to the |
PR just got merged - takes about 10 min to roll out |
Problem Statement
Since the docs are great for boosting our SEO traffic, I was wondering if we could extend the promo banner beyond the homepage.
Currently, it's managed through
src/components/banner
with no real option on which page we would like to target, and based on the codebase, it's only published on the docs homepage (though please let me know if I'm missing something).Solution Brainstorm
We would like the following functionality:
src/components/banner/index.tsx
As an example of general functionality, it can be found on
static-sites
(packages/shared/components/Banner
).The text was updated successfully, but these errors were encountered: