-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could you please update ALL your documentation #8953
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-issues-suggested-fix for triage ⏲️ |
Obviously don't want to bump for bumps sake. Capture console for one.
However Sentry.Replay is also deprecated? The CLI added something already deprecated? |
This doesn't look like the right product area, I'm going to transfer over to docs. |
Assigning to @getsentry/support for routing ⏲️ |
At least documentation for NodeJS, Koa, Express, Vue, NextJS are outdated. |
Hey, I will close this issue in favor of #8982 where we are tracking this. For the koa specific one, please see my comment here: #8973 (comment) |
Shouldn't the approach be - write the docs and solidify the new API with customers, and then deprecate? |
There is nothing wrong with using the deprecated methods. They still work fine and we commit that they will continue to work fine in the v7 cycle. For some APIs a proper, full replacement relies on multiple pieces being in place, making it hard to document the full replacement in advance every time. I understand that this can still be annoying, and we're actively working to update the docs right now. |
To clarify, I have no issues with using the deprecated methods, but every developer looking to keep their codebase up to date will immediately go looking to see what they should be using and therefore waste their time. It would be better to only deprecate when you want developers to move away from a given API and have something for them to move to. Especially at sentry's scale. On top of this, it is now my duty to go and check out your docs every so often to see if the new APIs are ready, resulting even more time wasted. |
So for everything we deprecate there is immediately an entry in the So if you see something in your codebase that is deprecated, you can choose to either ignore it for now until you update to the next major, or you can read the deprecation message that is provided via jsdoc to see how you need to update this. And for more details, you can refer to the MIGRATION.md file, which has more details on what is deprecated and how to replace it. These are living documents and are always up to date with the actual code base, and are also the only official place we maintain about deprecations. To be clear, everything that is being deprecated already has a replacement. We spent a lot of effort ensuring this. The replacement is also always documented in the MIGRATION.md file as well as in the jsdoc deprecation message, at the time the deprecation is added. The only thing that we have not updated fully in time is the docs, but that should not affect anybody updating their application too much, it is only annoying for users getting started that start out with code that is deprecated (which, again, I totally understand and agree that it is annoying and not ideal, and we are working to address this). I will try to see if we can add a note to the docs themselves pointing this out and refering to the migration doc, maybe that helps avoid confusion in the future. |
Environment
SaaS (https://sentry.io/)
Steps to Reproduce
Open any documentation or code sample after project creation.
Configure Koa SDK
configureScope
deprecatedgetCurrentHub
deprecatedAnd there is no documentation how to replace deprecated methods.
CaptureConsole
https://docs.sentry.io/platforms/javascript/configuration/integrations/captureconsole/
CaptureConsole
is deprecated and there is no documentation about how to usecaptureConsoleIntegration
.Expected Result
Documentation and code samples are update.
Actual Result
Documentation and code samples are outdated.
Product Area
Other
Link
any
DSN
any
Version
7.94.1
The text was updated successfully, but these errors were encountered: