feat(node): Add docs for async context apis #6641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
shanamatthews,
a team,
mydea and
lforst
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9 tasks
shanamatthews
approved these changes
Apr 13, 2023
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
We actually don't have a koa integration, so the koa docs are a guide on how to manually instrument the framework with sentry. The example with |
kamilkisiela
added a commit
to graphql-hive/console
that referenced
this pull request
Apr 13, 2023
lforst
approved these changes
Apr 13, 2023
| }, | ||
| }); | ||
| Sentry.runWithAsyncContext( | ||
| async hub => { |
There was a problem hiding this comment.
A question about this API: Why do we pass the hub as argument? Couldn't we just tell users to call Sentry.getCurrentHub() inside instead?
There was a problem hiding this comment.
We discussed offline and decided this was fine, since very few people are going to use this API anyway.
kamilkisiela
added a commit
to graphql-hive/console
that referenced
this pull request
Apr 17, 2023
kamilkisiela
added a commit
to graphql-hive/console
that referenced
this pull request
Apr 17, 2023
kamilkisiela
added a commit
to graphql-hive/console
that referenced
this pull request
Apr 17, 2023
kamilkisiela
added a commit
to graphql-hive/console
that referenced
this pull request
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/sentry-javascript#7691
ref getsentry/sentry-javascript#7817
In the new upcoming version of the Node SDK, we now expose an API allowing users to isolate their requests to prevent breadcrumbs/tags/spans from leaking across requests. This PR documents that.
Before users had to manually use Node's domains API to do this, but now we've abstracted this away from them. To make this easier, we've updated the Koa docs to stop using domains directly, but instead use the new
runWithAsyncContextAPI.Note: only merge when
7.48.0is released.