Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oban ErrorReporter can crash and detach future telemetry events #805

Closed
GregMefford opened this issue Oct 3, 2024 · 7 comments · Fixed by #807
Closed

Oban ErrorReporter can crash and detach future telemetry events #805

GregMefford opened this issue Oct 3, 2024 · 7 comments · Fixed by #807

Comments

@GregMefford
Copy link

Environment

What version are you running? Etc.

  • Sentry version: 10.7.1
  • Oban version: 2.18.3

Steps to Reproduce

Looking through server logs for disconnected telemetry handlers, I found the log below, which appears to be due to a :timeout error.

Expected Result

I think this code should probably account for non-Exceptions somehow.

Actual Result

In this example, the exception is :timeout rather than being an Exception struct.

Handler Sentry.Integrations.Oban.ErrorReporter has failed and has been detached. Class=:error
Reason=:undef
Stacktrace=[
  {:timeout, :__struct__, [], []},
  {Sentry.Integrations.Oban.ErrorReporter, :handle_event, 4,
   [file: ~c"lib/sentry/integrations/oban/error_reporter.ex", line: 40]},
  {:telemetry, :"-execute/3-fun-0-", 4,
   [file: ~c"/tmp/project/deps/telemetry/src/telemetry.erl", line: 167]},
  {:lists, :foreach_1, 2, [file: ~c"lists.erl", line: 1442]},
  {Oban.Queue.Executor, :emit_event, 1,
   [file: ~c"lib/oban/queue/executor.ex", line: 284]},
  {Oban.Backoff, :with_retry, 3, [file: ~c"lib/oban/backoff.ex", line: 108]},
  {Task.Supervised, :invoke_mfa, 2,
   [file: ~c"lib/task/supervised.ex", line: 101]},
  {Task.Supervised, :reply, 4, [file: ~c"lib/task/supervised.ex", line: 36]}
]
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Oct 3, 2024
@whatyouhide
Copy link
Collaborator

@savhappy any chance you could look into this?

@savhappy
Copy link
Collaborator

savhappy commented Oct 6, 2024

@whatyouhide yep yep!

@savhappy
Copy link
Collaborator

savhappy commented Oct 9, 2024

Okay, I had a look and we'll forward anything not matching an exception to capture_message instead. Will have a PR out shortly! Thanks @GregMefford for the report 💟

@savhappy
Copy link
Collaborator

savhappy commented Oct 9, 2024

PR #807 out for review

@GregMefford
Copy link
Author

Hey, I was just curious what release cadence I should expect. I've been checking the releases on GitHub once in a while to see when we can get this fix deployed in our app, but it looks like the latest release was September 5. Thanks! ❤

@savhappy
Copy link
Collaborator

@GregMefford release 10.8.0 is out as of this morning!

@whatyouhide
Copy link
Collaborator

@GregMefford 10.8.0 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants