-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oban ErrorReporter can crash and detach future telemetry events #805
Comments
@savhappy any chance you could look into this? |
@whatyouhide yep yep! |
Okay, I had a look and we'll forward anything not matching an exception to |
PR #807 out for review |
Hey, I was just curious what release cadence I should expect. I've been checking the releases on GitHub once in a while to see when we can get this fix deployed in our app, but it looks like the latest release was September 5. Thanks! ❤ |
@GregMefford release 10.8.0 is out as of this morning! |
@GregMefford 10.8.0 is out! |
Environment
What version are you running? Etc.
10.7.1
2.18.3
Steps to Reproduce
Looking through server logs for disconnected telemetry handlers, I found the log below, which appears to be due to a
:timeout
error.Expected Result
I think this code should probably account for non-Exceptions somehow.
Actual Result
In this example, the
exception
is:timeout
rather than being anException
struct.The text was updated successfully, but these errors were encountered: