Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload libsentry symbols on tag builds #1105

Closed
bruno-garcia opened this issue Dec 10, 2020 · 8 comments
Closed

Upload libsentry symbols on tag builds #1105

bruno-garcia opened this issue Dec 10, 2020 · 8 comments

Comments

@bruno-garcia
Copy link
Member

Use symbol collector to upload symbols of sentry native during a tagged CI run

@marandaneto marandaneto added the NDK Android NDK label Dec 10, 2020
@marandaneto
Copy link
Contributor

if we do it only on CI, we depend on #1063

@bruno-garcia
Copy link
Member Author

@marandaneto
Copy link
Contributor

related to getsentry/sentry-native#728

@marandaneto
Copy link
Contributor

marandaneto commented Feb 5, 2021

@bruno-garcia I might have found a workaround for that.

https://android-developers.googleblog.com/2020/10/android-studio-41.html

See the flag android.buildTypes.release.ndk.debugSymbolLevel

Supported values are 'none' (default, no native debug metadata will be packaged),
* 'symbol_table' (only the symbol tables will be packaged), and 'full' (the debug info and
* symbol tables will be packaged)

that means, our AAR files will contain debug symbols if we enable this option, so when people upload their own symbols, sentry's debug symbols will be uploaded too.
this would increase the AAR's size, but only by downloading them, the final App compilation will strip out the symbols anyway, wdyt?
I'd need to test that, of course.

ps: we already use AGP 4.1.2 so this would be actually possible

@bruno-garcia
Copy link
Member Author

Sounds like a good idea. Although it's convenient to users that we upload the symbols for them and leave it in a generic Android bucket, instead of each project having a copy of it.

@marandaneto
Copy link
Contributor

Sounds like a good idea. Although it's convenient to users that we upload the symbols for them and leave it in a generic Android bucket, instead of each project having a copy of it.

yep, I agree, this would be a temporary workaround while we don't fully automatize this process over craft

@marandaneto
Copy link
Contributor

current commands are:

export VERSION={version}
cd sentry-android-ndk
{SymbolCollectorFolder}/SymbolCollector.Console --upload directory --path ./ --batch-type android --bundle-id sentry-android-ndk-$VERSION --server-endpoint https://symbol-collector.services.sentry.io
cd ..

@marandaneto
Copy link
Contributor

@bruno-garcia bruno-garcia moved this to Needs Discussion in Mobile & Cross Platform SDK Aug 4, 2022
@kahest kahest moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants