Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods from tests #1445

Closed
marandaneto opened this issue Apr 28, 2021 · 4 comments
Closed

Remove deprecated methods from tests #1445

marandaneto opened this issue Apr 28, 2021 · 4 comments
Labels
repository maintenance
Milestone
6.0.0

Comments

@marandaneto
Copy link
Contributor

eg sentry-java/sentry/src/test/java/io/sentry/GsonSerializerTest.kt: (410, 23): 'constructor SdkVersion()' is deprecated. Deprecated in Java
@bruno-garcia
Copy link
Member

Alternatively, if possible we could suppress the warning and delete the test only when the code gets deleted

@marandaneto
Copy link
Contributor Author

marandaneto commented May 3, 2021 •
edited
Loading

as we do a major bump, we could also delete @Deprecated fields as SentryProperties.isEnableTracing
@maciejwalkowiak wdyt?

@maciejwalkowiak
Copy link
Contributor

👍

@marandaneto marandaneto added this to the 6.0.0 milestone Jun 16, 2021
@marandaneto marandaneto mentioned this issue Jan 18, 2022
Closed
@marandaneto
Copy link
Contributor Author

Addressed on #1875

@bruno-garcia bruno-garcia moved this to Needs Discussion in Mobile & Cross Platform SDK Aug 4, 2022
@kahest kahest moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repository maintenance
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
6.0.0
Development

No branches or pull requests
3 participants
@maciejwalkowiak @bruno-garcia @marandaneto