-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or fix IUnknownPropertiesConsumer implementation #1497
Comments
Is there a way to do this with the current reflection-based serialization approach? We've been reconsidering vendoring the handful Gson classes needed to do 'manual' serialization/deserialization and drop the Gson dependency. While doing so we could address this issue by keeping unknown json keys into a It will hopefully address #1420 too since we wouldn't depend on Gson. Another added benefit is to avoid the Gson version conflict that comes up from time to time:
|
I believe it's possible to fix with the current implementation, yes, it'd require adapters for every single protocol class probably. |
closed by #1554 |
Relates to #1420 but can be done standalone.
The
IUnknownPropertiesConsumer
implementation today is different than expected, we can either fix it or remove it as the 'unknown' map that this implementation generates is usually dropped during ingestion.Not all protocol classes accept non-mapped fields, but we implement
IUnknownPropertiesConsumer
for every protocol class, this should also be addressed.It's not a high priority issue though because it only affects hybrid SDKs or when one downgrade the SDK and has a cached envelope that has now a field that is unknown.
The text was updated successfully, but these errors were encountered: