Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send user.ip_address = {{ auto }} when sendDefaultPii is true #1015

Closed
bruno-garcia opened this issue Oct 27, 2020 · 3 comments · Fixed by #1144
Closed

Send user.ip_address = {{ auto }} when sendDefaultPii is true #1015

bruno-garcia opened this issue Oct 27, 2020 · 3 comments · Fixed by #1144
Assignees
@maciejwalkowiak
Labels
enhancement New feature or request

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Oct 27, 2020 •
edited
Loading

If no explicit IpAddress was set by the user code (or framework integration) the SDK should set {{ auto }} which tells the server to infer the IP Address to client connection as the user.ip_address.

This is true for all SDKs. Like: getsentry/sentry-dotnet#561
@marandaneto marandaneto added the enhancement New feature or request label Oct 29, 2020
@lucas-zimerman
Copy link
Contributor

I believe it should set "{{auto}}" ? @bruno-garcia

@marandaneto
Copy link
Contributor

Yep @lucas-zimerman is right, thanks for pointing this out

@bruno-garcia bruno-garcia changed the title Send user.ip_address = {{ default }} when sendDefaultPii is true Send user.ip_address = {{ auto }} when sendDefaultPii is true Nov 1, 2020
@bruno-garcia
Copy link
Member Author

Thanks @lucas-zimerman

@marandaneto marandaneto mentioned this issue Nov 14, 2020
Merged
8 tasks
@maciejwalkowiak maciejwalkowiak self-assigned this Nov 23, 2020
@maciejwalkowiak maciejwalkowiak mentioned this issue Dec 30, 2020
Merged
4 tasks
maciejwalkowiak added a commit that referenced this issue Dec 31, 2020
@maciejwalkowiak
Merge branch 'main' into gh-1015
de0a5ef
maciejwalkowiak added a commit that referenced this issue Jan 4, 2021
@maciejwalkowiak
Merge branch 'gh-1015' of https://github.com/getsentry/sentry-java into
6df9856 
gh-1015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maciejwalkowiak maciejwalkowiak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send user.ip_address = {{auto}} when sendDefaultPii is true getsentry/sentry-java
4 participants
@maciejwalkowiak @bruno-garcia @marandaneto @lucas-zimerman