Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught Exception "Deno.permissions.querySync is not a function" when using Deno Deploy CLI #10521

Closed
chillbrodev opened this issue Jan 19, 2024 · 7 comments · Fixed by #13378
Closed

Uncaught Exception "Deno.permissions.querySync is not a function" when using Deno Deploy CLI #10521

chillbrodev opened this issue Jan 19, 2024 · 7 comments · Fixed by #13378
Labels
Meta: Help Wanted Package: deno Issues related to the Sentry Deno SDK

Comments

@chillbrodev
Copy link

chillbrodev commented Jan 19, 2024 •
edited
Loading

Environment

7.99.0

Steps to Reproduce

  1. Import Sentry via: import * as Sentry from 'https://deno.land/x/sentry@7.94.1/index.mjs'; in any typescript file.
  2. Run Deno Deploy: deployctl deploy --project=<SOME_PROJECT> ./src/main.ts
  3. See exception:
 Using config file 'deno.jsonc'
✔ Deploying to project <SOME_PROJECT>.
✔ Entrypoint: /src/main.ts
ℹ Uploading all files from the current dir (server)
✔ Found 62 assets.
✔ Uploaded 5 new assets.
✖ Deployment failed.
error: The deployment failed: UNCAUGHT_EXCEPTION

TypeError: Deno.permissions.querySync is not a function
    at getHostName (https://deno.land/x/sentry@7.94.1/index.mjs:11183:35)
    at new DenoClient (https://deno.land/x/sentry@7.94.1/index.mjs:11215:41)
    at initAndBind (https://deno.land/x/sentry@7.94.1/index.mjs:10396:18)
    at Module.init (https://deno.land/x/sentry@7.94.1/index.mjs:12445:3)
    at file:///src/src/main.ts:25:9
    at eventLoopTick (ext:core/01_core.js:182:7)

This is noted on Deno Deploy Github here as well. denoland/deploy_feedback#527 (comment)

Expected Result

Expected result is that Deno Deploy works without issue.
Deployment works when using Sentry via the npm import: import * as Sentry from 'npm:@sentry/node'

Actual Result

Deno Deploy fails. Here are the logs from Deno Deploy portal:

Cloning repository (100%)
Downloaded
file:///src/src/main.ts
Downloaded
https://deno.land/std@0.202.0/dotenv/mod.ts
Downloaded
https://deno.land/x/hono@v3.12.0/mod.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware.ts
Downloaded
file:///src/src/clients/redis/redis_client.ts
Downloaded
file:///src/src/features/articles/articles.service.ts
Downloaded
file:///src/src/clients/project_media/project_media_client.ts
Downloaded
file:///src/src/features/articles/articles.controller.ts
Downloaded
file:///src/src/middlewares/error_handler/error_handler.ts
Downloaded
https://deno.land/x/sentry@7.94.1/index.mjs
Downloaded
file:///src/src/features/account/account.controller.ts
Downloaded
file:///src/src/features/account/account.service.ts
Downloaded
file:///src/src/clients/project_account/project_account_client.ts
Downloaded
file:///src/src/middlewares/logger/custom_hono_logger.ts
Downloaded
https://deno.land/std@0.53.0/fmt/colors.ts
Downloaded
https://deno.land/x/hono@v3.12.0/hono.ts
Downloaded
https://deno.land/x/hono@v3.12.0/http-exception.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/reg-exp-router/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/trie-router/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/smart-router/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/pattern-router/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/linear-router/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/validator/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/client/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/basic-auth/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/bearer-auth/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/cache/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/helper/cookie/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/compress/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/cors/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/csrf/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/etag/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/helper/html/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/jsx/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/jsx-renderer/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/jwt/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/logger/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/powered-by/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/timing/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/pretty-json/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/middleware/secure-headers/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/adapter/deno/serve-static.ts
Downloaded
https://deno.land/x/redis@v0.32.0/mod.ts
Downloaded
file:///src/src/clients/project_media/models/project_media.interfaces.ts
Downloaded
file:///src/src/features/articles/articles.interfaces.ts
Downloaded
file:///src/src/clients/project_media/find_included.ts
Downloaded
file:///src/src/features/articles/parser/content_parser.ts
Downloaded
file:///src/src/features/articles/parser/errors/parse_data_failed.ts
Downloaded
file:///src/src/features/articles/parser/interest_parser.ts
Downloaded
file:///src/src/features/articles/parameters/get_articles_params.ts
Downloaded
file:///src/src/features/articles/filters/is_live_blog_filter.ts
Downloaded
file:///src/src/features/articles/filters/air_date_in_future_filter.ts
Downloaded
file:///src/src/clients/project_media/errors/project_media_not_found.ts
Downloaded
file:///src/src/referer.ts
Downloaded
file:///src/src/errors/ensure_error.ts
Downloaded
file:///src/src/middlewares/logger/sentry_exception_logger.ts
Downloaded
file:///src/src/clients/project_account/errors/project_account_error.ts
Downloaded
file:///src/src/clients/project_account/models/project_account.interface.ts
Downloaded
file:///src/src/features/account/account.interfaces.ts
Downloaded
https://deno.land/x/zod@v3.22.4/mod.ts
Downloaded
https://deno.land/x/hono@v3.12.0/hono-base.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/reg-exp-router/router.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/trie-router/router.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/smart-router/router.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/pattern-router/router.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/linear-router/router.ts
Downloaded
https://deno.land/x/hono@v3.12.0/validator/validator.ts
Downloaded
https://deno.land/x/hono@v3.12.0/client/client.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/buffer.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/encode.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/cookie.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/crypto.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/html.ts
Downloaded
https://deno.land/x/hono@v3.12.0/jsx/components.ts
Downloaded
https://deno.land/x/hono@v3.12.0/jsx/streaming.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/jwt/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/context.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/url.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/filepath.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/mime.ts
Downloaded
https://deno.land/x/redis@v0.32.0/protocol/shared/types.ts
Downloaded
https://deno.land/x/redis@v0.32.0/redis.ts
Downloaded
https://deno.land/x/redis@v0.32.0/errors.ts
Downloaded
file:///src/src/features/articles/parser/article_content.interfaces.ts
Downloaded
file:///src/src/logger.ts
Downloaded
file:///src/src/errors/base_error.ts
Downloaded
https://deno.land/x/zod@v3.22.4/index.ts
Downloaded
https://deno.land/x/hono@v3.12.0/compose.ts
Downloaded
https://deno.land/x/hono@v3.12.0/request.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/reg-exp-router/node.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/reg-exp-router/trie.ts
Downloaded
https://deno.land/x/hono@v3.12.0/router/trie-router/node.ts
Downloaded
https://deno.land/x/hono@v3.12.0/client/utils.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/jwt/jwt.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/stream.ts
Downloaded
https://deno.land/x/redis@v0.32.0/connection.ts
Downloaded
https://deno.land/x/redis@v0.32.0/executor.ts
Downloaded
https://deno.land/x/redis@v0.32.0/pipeline.ts
Downloaded
https://deno.land/x/redis@v0.32.0/pubsub.ts
Downloaded
https://deno.land/x/redis@v0.32.0/stream.ts
Downloaded
https://deno.land/std@0.208.0/log/mod.ts
Downloaded
https://deno.land/x/zod@v3.22.4/external.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/body.ts
Downloaded
https://deno.land/x/hono@v3.12.0/utils/jwt/types.ts
Downloaded
https://deno.land/x/redis@v0.32.0/protocol/deno_streams/mod.ts
Downloaded
https://deno.land/x/redis@v0.32.0/backoff.ts
Downloaded
https://deno.land/x/redis@v0.32.0/internal/symbols.ts
Downloaded
https://deno.land/x/redis@v0.32.0/vendor/https/deno.land/std/async/deferred.ts
Downloaded
https://deno.land/x/redis@v0.32.0/vendor/https/deno.land/std/async/delay.ts
Downloaded
https://deno.land/x/redis@v0.32.0/internal/encoding.ts
Downloaded
https://deno.land/std@0.208.0/log/logger.ts
Downloaded
https://deno.land/std@0.208.0/log/handlers.ts
Downloaded
https://deno.land/std@0.208.0/assert/assert.ts
Downloaded
https://deno.land/std@0.208.0/log/levels.ts
Downloaded
https://deno.land/x/zod@v3.22.4/errors.ts
Downloaded
https://deno.land/x/zod@v3.22.4/helpers/parseUtil.ts
Downloaded
https://deno.land/x/zod@v3.22.4/helpers/typeAliases.ts
Downloaded
https://deno.land/x/zod@v3.22.4/helpers/util.ts
Downloaded
https://deno.land/x/zod@v3.22.4/types.ts
Downloaded
https://deno.land/x/zod@v3.22.4/ZodError.ts
Downloaded
https://deno.land/x/redis@v0.32.0/vendor/https/deno.land/std/io/buf_reader.ts
Downloaded
https://deno.land/x/redis@v0.32.0/vendor/https/deno.land/std/io/buf_writer.ts
Downloaded
https://deno.land/x/redis@v0.32.0/protocol/deno_streams/reply.ts
Downloaded
https://deno.land/x/redis@v0.32.0/protocol/deno_streams/command.ts
Downloaded
https://deno.land/std@0.203.0/async/deferred.ts
Downloaded
https://deno.land/std@0.203.0/async/delay.ts
Downloaded
https://deno.land/std@0.208.0/fmt/colors.ts
Downloaded
https://deno.land/std@0.208.0/fs/exists.ts
Downloaded
https://deno.land/std@0.208.0/io/buf_writer.ts
Downloaded
https://deno.land/std@0.208.0/assert/assertion_error.ts
Downloaded
https://deno.land/x/zod@v3.22.4/locales/en.ts
Downloaded
https://deno.land/x/zod@v3.22.4/helpers/enumUtil.ts
Downloaded
https://deno.land/x/zod@v3.22.4/helpers/errorUtil.ts
Downloaded
https://deno.land/x/zod@v3.22.4/helpers/partialUtil.ts
Downloaded
https://deno.land/std@0.203.0/io/buf_reader.ts
Downloaded
https://deno.land/std@0.203.0/io/buf_writer.ts
Downloaded
https://deno.land/x/redis@v0.32.0/protocol/shared/reply.ts
Downloaded
https://deno.land/x/redis@v0.32.0/protocol/shared/command.ts
Downloaded
https://deno.land/std@0.208.0/bytes/copy.ts
Downloaded
https://deno.land/std@0.203.0/assert/assert.ts
Downloaded
https://deno.land/std@0.203.0/bytes/copy.ts
Downloaded
https://deno.land/x/redis@v0.32.0/vendor/https/deno.land/std/bytes/concat.ts
Downloaded
https://deno.land/std@0.203.0/assert/assertion_error.ts
Downloaded
https://deno.land/std@0.203.0/bytes/concat.ts
Packaging complete
Error The deployment failed: UNCAUGHT_EXCEPTION

TypeError: Deno.permissions.querySync is not a function
    at getHostName (https://deno.land/x/sentry@7.94.1/index.mjs:11183:35)
    at new DenoClient (https://deno.land/x/sentry@7.94.1/index.mjs:11215:41)
    at initAndBind (https://deno.land/x/sentry@7.94.1/index.mjs:10396:18)
    at Module.init (https://deno.land/x/sentry@7.94.1/index.mjs:12445:3)
    at file:///src/src/main.ts:25:9
    at eventLoopTick (ext:core/01_core.js:182:7)

EDIT: Still failing on 7.99.0, SDK version updated
@chillbrodev chillbrodev mentioned this issue Jan 19, 2024
Open
@chillbrodev
Copy link
Author

@getsentry-bot Bump

@chillbrodev chillbrodev mentioned this issue Feb 5, 2024
Closed
3 tasks
@lforst lforst transferred this issue from getsentry/sentry-deno Feb 6, 2024
@lforst
Copy link
Member

lforst commented Feb 6, 2024

Hm this sucks. It looks like an upstream issue to me that deno deploy should fix. We don't have the capacity to fix this right now so I'll backlog. Maybe you can work around this with the workaround described here: denoland/deploy_feedback#527 (comment)

@chillbrodev
Copy link
Author

Hm this sucks. It looks like an upstream issue to me that deno deploy should fix. We don't have the capacity to fix this right now so I'll backlog. Maybe you can work around this with the workaround described here: denoland/deploy_feedback#527 (comment)

@lforst Sounds good, I'll look into the workaround. I switched back to using the npm package for now and that is working for me. I also didn't realize that posting issues on sentry-deno open an issue here. TIL.

@AbhiPrasad
Copy link
Member

From Deno Discord: https://discord.com/channels/684898665143206084/826085979344470037/1209268059173298257

I thnk *Sync functions are all omitted intentionally and the sentry module should be updated to use the async apis ideally

@AbhiPrasad AbhiPrasad added the Package: deno Issues related to the Sentry Deno SDK label Mar 1, 2024
@pawelgrzybek
Copy link

Do you know if there is any progress on trying to resolve this one Sentry/Deno side? Is there any way I could help to progress with this one?

I encountered the same bug which unfortunately makes Sentry not an option for me to use on Deno projects deployed to Deno Deploy.

@lforst lforst mentioned this issue Aug 14, 2024
Merged
@lforst
Copy link
Member

lforst commented Aug 14, 2024

@pawelgrzybek I just realized that we probably don't have to rely on querySync and opened a pr to fix. We will probably release this within the next two weeks. (Next week Sentry has a hackathon we won't be around for normal operation.) #13378

@pawelgrzybek
Copy link

Thanks for info and rapid reaction @lforst , looking forward for this one to be merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta: Help Wanted Package: deno Issues related to the Sentry Deno SDK
Projects
GitHub Issues with 👀 2
Archived in project
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deno): Don't rely on Deno.permissions.querySync getsentry/sentry-javascript
4 participants
@chillbrodev @pawelgrzybek @lforst @AbhiPrasad