Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simplify shouldCreateSpanForRequest #2867

Merged
merged 1 commit into from
Sep 1, 2020
Merged

feat: Simplify shouldCreateSpanForRequest #2867

merged 1 commit into from
Sep 1, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Aug 31, 2020

I was writing docs on how users can filter out Spans and noticed that the API is very hard to use.
getsentry/sentry-docs#2133

This change makes it so it works as expected.

@HazAT HazAT requested a review from kamilogorek as a code owner August 31, 2020 12:13
@HazAT HazAT self-assigned this Aug 31, 2020
@HazAT HazAT mentioned this pull request Aug 31, 2020
Closed
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.67 KB (-0.01% 🔽)
@sentry/browser - Webpack 18.47 KB (0%)
@sentry/react - Webpack 18.47 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.79 KB (+0.05% 🔺)

rhcarvalho
rhcarvalho approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, this means the default func always applies. LGTM 👍

@HazAT HazAT merged commit def5490 into master Sep 1, 2020
@HazAT HazAT deleted the feat/shouldCreateSpanForRequest branch September 1, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HazAT @rhcarvalho