refactor(ember): Use @embroider/macros instead of runInDebug for @sentry/ember

[mydea]

This ensures that the debug code is actually stripped from production builds, to produce (slightly, but still) smaller production builds.

Small explanation, if you are not aware of @embroider/macros: This is a purely build-time addon that will strip "dead" code branches of conditions using macroCondition().

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[kamilogorek]

cc @k-fish

[k-fish]

Thanks for the catch!

Ah that's interesting that it doesn't get stripped despite the docs saying it does here: https://github.com/emberjs/ember.js/blob/29accc754fc05a80c236dfcd75abaf08c45514b7/packages/%40ember/debug/index.ts#L267, I see you've brought it up on the ember.js repo, but maybe before it's fully removed that doc can be changed?

I'm going to hold off merging this in until the ember tests are re-enabled on PR's (which should be soon-ish).

[mydea]

Good point, I made a PR to update the docs (emberjs/ember.js#19126).

[mydea]

I have updated the PR to also use @embroider/macros to test if in test environment, instead of Ember.testing.

[k-fish]

Why did you add babel__core?

[mydea]

Hmm it resulted in type errors without it, but I just checked again, not anymore! But I have updated @embroider/macros a few versions in between, that probably improved somewhat there. I removed it!

[k-fish]

Thanks!