fix: Add event type to item header when envelopes are forced #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team,
AbhiPrasad and
vladanpaunovic
and removed request for
a team
8 tasks
HazAT
approved these changes
Jun 15, 2021
size-limit report
|
rhcarvalho
reviewed
Jun 15, 2021
| @@ -47,7 +47,7 @@ export interface Event { | |||
| } | |||
|
|
|||
| /** JSDoc */ | |||
| export type EventType = 'transaction'; | |||
| export type EventType = 'event' | 'transaction'; | |||
There was a problem hiding this comment.
I thought this EventType refer to Error, Transaction, Default? Which unfortunately might not match envelope header requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An oversight that prevents
tunnelfrom working correctly. In the times when there was only a single event type, we didn't specifyevent.type === 'event'because it was redundant. Now it's not.