fix(browser): Make sure handler exists for LinkedErrors Integration #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should port the fixes done in the Node SDK in #2742 to the browser SDK. This makes sure that the handler class method is defined in the linked errors integration.
size-limit report
|
|
Outside the scope of this PR probably, but d'ya think it might be worth consolidating the node and browser versions of this integration? FWICT, the only real difference is that on the node side it's async: https://www.diffchecker.com/n7aluMTf. Might save us future such headaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should port the fixes done in the Node SDK in #2742 to the browser SDK.
This makes sure that the handler class method is defined in the linked errors integration.
See Sentry issue: https://sentry.io/share/issue/c654e9998c8e447d92d93e0da3222366/