Fix metrics borking module load in worker #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthb
force-pushed
the
fix-metrics-borking-module-load-in-worker
branch
from
0f07e89 to
01a267a
Compare
AbhiPrasad
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
Thanks for the fix!
Test case sidenote 1: I noticed state bleeding between test cases. If this new test case is placed after the existing initializes trackers when not on node and... case, then it fails because that existing test case adds properties onto the global object and leaves them there. It should clean up, but I've not tried to address this.
@onurtemizkan Could you take a look at this and investigate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal fix for #3934
Added a test case exercising this fix.
Test case sidenote 1: I noticed state bleeding between test cases. If this new test case is placed after the existing
initializes trackers when not on node and...case, then it fails because that existing test case adds properties onto the global object and leaves them there. It should clean up, but I've not tried to address this.Test case sidenote 2: when I remove my fix to verify that the new test case fails, then actually the whole test suite fails to run because the
expectlibrary borks onprocessbeing falsy --- despite the process backup having been put back onto the global object beforeexpectis called. This must be some jest execution reordering black magic and I have not tried to troubleshoot it.Tested manually that this fixes the problem in my setup.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).