Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(angular): Add Angular 13 to peer dep #4183

Merged
merged 1 commit into from
Nov 25, 2021
Merged

feat(angular): Add Angular 13 to peer dep #4183

merged 1 commit into from
Nov 25, 2021

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad requested review from a team, rhcarvalho and iker-barriocanal and removed request for a team November 25, 2021 13:21
@AbhiPrasad AbhiPrasad mentioned this pull request Nov 25, 2021
Closed
1 task
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.49 KB (+0.01% 🔺)
@sentry/browser - Webpack 23.37 KB (0%)
@sentry/react - Webpack 23.4 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.93 KB (+0.01% 🔺)

iker-barriocanal
iker-barriocanal approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the original issue:

v6.15.0 seems to be compatible with Angular 13+

Approving the PR, assuming this has been tested.

@AbhiPrasad AbhiPrasad merged commit 4887f98 into master Nov 25, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-angular-13 branch November 25, 2021 15:48
@scifresh
Copy link

Thanks a lot for this! :-) Unfortunately the publish on npm is still missing.

@AbhiPrasad
Copy link
Member Author

Yup, this will be part of the next release. Will update when that happens :)

@scifresh
Copy link

Oh thanks, I'm on pins and needles ;)

9034725985 pushed a commit to kusl/angulartwelve that referenced this pull request Dec 4, 2021
@teamkushal
update sentry manually
a5ed200 
thanks for fixing angular 13 compat :)
getsentry/sentry-javascript#4183
@scifresh
Copy link

scifresh commented Dec 4, 2021

Any updates about this? When will be the next release?

@AbhiPrasad
Copy link
Member Author

Next release will be early next week

@AbhiPrasad
Copy link
Member Author

@scifresh release is out https://www.npmjs.com/package/@sentry/angular/v/6.16.0!

@scifresh
Copy link

@scifresh release is out https://www.npmjs.com/package/@sentry/angular/v/6.16.0!

Thank you! :)

onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
@AbhiPrasad @onurtemizkan
feat(angular): Add Angular 13 to peer dep (#4183)
a1ad7aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@rhcarvalho rhcarvalho Awaiting requested review from rhcarvalho rhcarvalho was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add compatibility with Angular 13
3 participants
@AbhiPrasad @scifresh @iker-barriocanal