"onerror" global handler doesn't set event.level = 'error'

[nag5000]

• Review the documentation: https://docs.sentry.io/
• Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• Use the latest release: https://github.com/getsentry/sentry-javascript/releases
• Provide a link to the affected event from your Sentry account

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

6.16.1

Description

1. GlobalHandlers integration is enabled (by default).

2. const script = document.createElement('script');
   script.text = 'throw new Error("oops");';
   document.body.appendChild(script);

3. event.level is undefined in beforeSend hook and /store POST payload also doesn't have this property.

Unlike onerror, unhandledrejection handler sets event.level = 'error':

sentry-javascript/packages/browser/src/integrations/globalhandlers.ts

Line 151 in c1341fd

event.level = 'error';

[AbhiPrasad]

This is the case because Relay, Sentry's event ingestion system, defaults the level to be error. https://github.com/getsentry/relay/blob/5f6f8012639f5d8385b9943e46ddad9d8925c949/relay-general/src/store/normalize.rs#L495-L498 - so we don't need to set it explicitly in the SDK.

We can change this though, for what purpose were you trying to grab event.level?

[nag5000]

I rely on event.level in beforeSend hook to filter out some events. Smth like that:

if (event.level === 'error') {
  const error = hint.originalException;
  if (someFn(error)) {
    return null;
  } 
}

defaults the level to be error

Ah, ok then, it's simply const level = event.level ?? 'error'?. But it would be nice to cover this in the documentation.

Also I can use duck typing if (hint.originalException), but I don't really like this approach.