Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport#send(SentryEnvelope) support for Hybrid SDKs #4417

Closed
marandaneto opened this issue Jan 19, 2022 · 1 comment
Closed

Transport#send(SentryEnvelope) support for Hybrid SDKs #4417

marandaneto opened this issue Jan 19, 2022 · 1 comment
Labels
Package: core Issues related to the Sentry Core SDK
Milestone

Comments

@marandaneto
Copy link

marandaneto commented Jan 19, 2022

The RN SDK uses the JS SDK for capturing and processing events, and if the Native layer is disabled, even the Transport.
We'd like to implement the User feedback and Attachments features (likely more features that depend on envelopes too, e.g. client reports) on the RN SDK but that is blocked since the transport only accepts an Event.

There should be a way to also customize theSentryEnvelope, since we'd need to read the RN Scope to get the attachments and pack it into the envelope before calling the transport.

Transactions are already sent as envelopes, but the difference is a Transaction is an Event with a different type + extra fields, so that worked just fine, since Attachments and User feedback is a totally different data structure/different envelope item, the way how it just does not work.

Issues: getsentry/sentry-react-native#1327 and getsentry/sentry-react-native#500

This issue is related to #4240

An option would be to override everything on the RN SDK, but since the JS SDK will or can offer proper support for it, it does not make sense for us to make it, this would duplicate code, more to maintain, and likely a new source of bugs, hence we'd like to get proper support for Envelopes.

@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Jan 19, 2022
@AbhiPrasad AbhiPrasad added Package: core Issues related to the Sentry Core SDK Status: Backlog labels Jan 19, 2022
@AbhiPrasad
Copy link
Member

This is done with v7. See the new transport API: https://github.com/getsentry/sentry-javascript/blob/7.x/MIGRATION.md#transport-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: core Issues related to the Sentry Core SDK
Projects
None yet
Development

No branches or pull requests

2 participants