ref(serverless): Remove rethrowAfterCapture use in AWS lambda wrapper
#4448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
force-pushed
the
kmclb-serverless-remove-no-rethrow-option
branch
from
99e6264 to
353eff4
Compare
size-limit report
|
lobsterkatie
force-pushed
the
kmclb-serverless-remove-no-rethrow-option
branch
from
353eff4 to
dedc5cf
Compare
AbhiPrasad
reviewed
Jan 24, 2022
AbhiPrasad
approved these changes
Jan 24, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…etsentry#11126) The `rethrowAfterCapture` option was deprecated in getsentry#4448, which was released in `6.17.2`. This finally removes the option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of the
rethrowAfterCaptureoption from the AWS handler-wrapping function@sentry/serverlessprovides. Without its use, the code follows the same path as it has been when the option has been set to its default value, which istrue. Though this is technically a breaking change for anyone who currently has it set tofalse,a) the option has never been documented,
b) it never should have existed in the first place (we do error monitoring, not error handling, meaning there should be no question as to whether we rethrow the error after recording it),
c) of all of the public projects on GH, only three are using it set explicitly to
true, and zero are using it set tofalse.For the three projects using it set to
true, there is no behavior change. Further, since all three are written in TS, the option hasn't been removed from theWrapperOptionstype, so that their continuing to pass it doesn’t cause type errors. It has been made optional, though, so that our non-use of it also doesn't cause type errors. There's also a TODO so that we remember to remove it in v7.Fixes #3364.