Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled errors are captured as handled errors (@sentry/node) #5375

Closed
3 tasks done
raulbrennersc opened this issue Jul 6, 2022 · 5 comments
Closed
3 tasks done
Labels
Package: node Issues related to the Sentry Node SDK Type: Bug

Comments

@raulbrennersc
Copy link

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/node

SDK Version

7.3.1

Framework Version

7.3.1

Link to Sentry event

No response

Steps to Reproduce

  1. Application throws an error
  2. The error is not handled by the application
  3. The error is captured by sentry

Expected Result

The error is captured as unhandled (handled = false)

image

Actual Result

The error is captured but is marked as handled (handled = true).

image

What is setting the handled flag as true?

@AbhiPrasad
Copy link
Member

Hey, thanks for writing in! Could you provide a more detailed reproduction to help us debug this? Are you using any integrations?

@AbhiPrasad AbhiPrasad added Status: Needs Reproduction Package: node Issues related to the Sentry Node SDK labels Jul 6, 2022
@raulbrennersc
Copy link
Author

Hi @AbhiPrasad, yes I'm using Sentry.Integrations.Http, Tracing.Integrations.Express and Tracing.Integrations.Postgres. I'm not really sure on what other details would help, this is my first time working with sentry.

@lobsterkatie
Copy link
Member

This is a known problem, unfortunately - our handled values don't make a ton of sense. Fixing it is in our backlog, but has unfortunately not yet made it onto the roadmap. This is helpful feedback, though! Knowing that it's relevant for more people helps us know what to prioritize.

@raulbrennersc
Copy link
Author

Ok, thanks for clarifying.

@AbhiPrasad
Copy link
Member

We've improved this in the latest version of the 7.x Sentry JavaScript SDKs. Please give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: node Issues related to the Sentry Node SDK Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants